Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(str): use enum for encoding #259

Merged
merged 1 commit into from Nov 8, 2021
Merged

feat(str): use enum for encoding #259

merged 1 commit into from Nov 8, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Nov 8, 2021

Signed-off-by: azjezz azjezz@protonmail.com

@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. Type: BC Break A change that will result in a backward compatibility break in the public API. labels Nov 8, 2021
@azjezz azjezz added this to the 2.0.0 milestone Nov 8, 2021
@azjezz azjezz self-assigned this Nov 8, 2021
@azjezz azjezz added this to To do in v2.0.0 via automation Nov 8, 2021
@azjezz azjezz mentioned this pull request Nov 8, 2021
Closed
@coveralls
Copy link

coveralls commented Nov 8, 2021 •
edited

Pull Request Test Coverage Report for Build 1432701656

  • 15 of 15 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1432621535: 0.0%
Covered Lines: 3081
Relevant Lines: 3081
💛 - Coveralls

@azjezz azjezz moved this from To do to Review in progress in v2.0.0 Nov 8, 2021
@azjezz
feat(str): use enum for encoding
73f176b 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz merged commit a31f604 into 2.0.x Nov 8, 2021
v2.0.0 automation moved this from Review in progress to Done Nov 8, 2021
@azjezz azjezz deleted the feature/str-encoding-enum branch November 8, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: BC Break A change that will result in a backward compatibility break in the public API. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
No open projects
v2.0.0
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azjezz @coveralls