Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(io): introduce write(), write_line(), write_error(), and write_error_line() functions #297

Merged
merged 1 commit into from Dec 2, 2021
Merged

feat(io): introduce write(), write_line(), write_error(), and write_error_line() functions #297

merged 1 commit into from Dec 2, 2021

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Dec 2, 2021 •
edited

Initially i wanted to also introduce IO\read() and IO\read_line(), but left them out of this PR for later time.

Note for later: while the write functions use writeAll, the read functions shouldn't use readAll(), as that will keep waiting forever if $max_bytes and/or $timeout have not been specified.

@azjezz
feat(io): introduce write(), write_line(), write_error(), and write_e…
ae49429 
…rror_line() functions

Signed-off-by: azjezz <azjezz@protonmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1532727516

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.0e**-05%**) to 99.97%
Totals Coverage Status
Change from base Build 1531163614: -2.0e-05%
Covered Lines: 3313
Relevant Lines: 3314
💛 - Coveralls

@azjezz azjezz self-assigned this Dec 2, 2021
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. labels Dec 2, 2021
@azjezz azjezz added this to the 2.0.0 milestone Dec 2, 2021
@azjezz azjezz added this to To do in v2.0.0 via automation Dec 2, 2021
@azjezz azjezz merged commit 6ce6f6f into 2.0.x Dec 2, 2021
v2.0.0 automation moved this from To do to Done Dec 2, 2021
@azjezz azjezz deleted the feat/io-write-read branch December 2, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
No open projects
v2.0.0
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azjezz @coveralls