Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(io): add streaming function #335

Merged
merged 3 commits into from May 7, 2022
Merged

feat(io): add streaming function #335

merged 3 commits into from May 7, 2022

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Feb 3, 2022

No description provided.

@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: On Hold Similar to blocked, but is assigned to someone. May also be assigned to someone because of their exp Type: Enhancement Most issues will probably ask for additions or changes. Experimental labels Feb 3, 2022
@azjezz azjezz added this to the 2.0.0 milestone Feb 3, 2022
@azjezz azjezz self-assigned this Feb 3, 2022
@azjezz azjezz added this to To do in v2.0.0 via automation Feb 3, 2022
@azjezz azjezz mentioned this pull request Feb 3, 2022
Merged
@coveralls
Copy link

coveralls commented Feb 3, 2022 •
edited

Pull Request Test Coverage Report for Build 2287048533

  • 30 of 39 (76.92%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 98.922%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/IO/streaming.php 24 33 72.73%
Files with Coverage Reduction New Missed Lines %
src/Psl/Shell/execute.php 2 93.55%
Totals Coverage Status
Change from base Build 2286989977: -0.02%
Covered Lines: 3305
Relevant Lines: 3341
馃挍 - Coveralls

azjezz
azjezz commented Feb 4, 2022
View reviewed changes
src/Psl/IO/streaming.php Outdated Show resolved Hide resolved
@azjezz azjezz added Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. and removed Status: On Hold Similar to blocked, but is assigned to someone. May also be assigned to someone because of their exp labels Feb 4, 2022
azjezz added 2 commits May 7, 2022 17:57
@azjezz
feat(io): add streaming function
a4fb106 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz
chore(shell): use io streaming
bfab29c 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz force-pushed the feat/io/streaming branch 4 times, most recently from cf3aa60 to bd252a6 Compare May 7, 2022 17:08
@azjezz
chore: fix coding standards
5ec0b05 
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz merged commit 3f2818d into 2.0.x May 7, 2022
v2.0.0 automation moved this from To do to Done May 7, 2022
@azjezz azjezz deleted the feat/io/streaming branch May 7, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Experimental Priority: Medium This issue may be useful, and needs some attention. Status: Revision Needed At least two people have seen issues in the PR that makes them uneasy. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
No open projects
v2.0.0
Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@azjezz @coveralls