Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tcp): add support for TLS/SSL in TCP #451

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

feat(tcp): add support for TLS/SSL in TCP #451

wants to merge 1 commit into from

Conversation

azjezz
Copy link
Owner

@azjezz azjezz commented Mar 26, 2024 •
edited

closes #342

  • TCP/TLS client support
  • TCP/TLS server support

@azjezz azjezz added this to the 3.0.0 milestone Mar 26, 2024
@azjezz azjezz added Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes. labels Mar 26, 2024
@azjezz azjezz self-assigned this Mar 26, 2024
@azjezz azjezz marked this pull request as draft March 26, 2024 07:55
@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited

Pull Request Test Coverage Report for Build 8497814574

Details

  • 27 of 488 (5.53%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.6%) to 89.451%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Psl/Network/Address.php 0 1 0.0%
src/Psl/Network/SocketOptions.php 4 5 80.0%
src/Psl/TCP/TLS/SecurityLevel.php 0 1 0.0%
src/Psl/TCP/TLS/Version.php 0 1 0.0%
src/Psl/Network/Internal/AbstractStreamServer.php 4 6 66.67%
src/Psl/TCP/ServerOptions.php 1 3 33.33%
src/Psl/TCP/TLS/Certificate.php 0 2 0.0%
src/Psl/TCP/Server.php 6 9 66.67%
src/Psl/TCP/ClientOptions.php 4 8 50.0%
src/Psl/TCP/connect.php 8 12 66.67%
Totals Coverage Status
Change from base Build 8488431262: -9.6%
Covered Lines: 4265
Relevant Lines: 4768
💛 - Coveralls

@azjezz azjezz force-pushed the feat/network-tls branch 2 times, most recently from e16144c to de97ccb Compare March 27, 2024 08:02
veewee
veewee reviewed Mar 29, 2024
View reviewed changes
src/Psl/TCP/TLS/Certificate.php
public function __construct(
public readonly string $certificateFile,
public readonly ?string $keyFile = null,
public readonly ?string $passphrase = null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[\SensitiveParameter]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! we actually have many places where we should add the attribute, mainly Psl\Password and Psl\Hash components.

@azjezz azjezz force-pushed the next branch 3 times, most recently from 198e166 to d42f3fa Compare March 30, 2024 04:43
@azjezz azjezz force-pushed the feat/network-tls branch 3 times, most recently from da09886 to 1a4ab80 Compare March 30, 2024 15:10
@azjezz azjezz marked this pull request as ready for review March 30, 2024 15:10
@azjezz azjezz force-pushed the feat/network-tls branch 4 times, most recently from 0d627b7 to 551f88c Compare March 31, 2024 11:22
@azjezz
feat(tcp): support TLS/SSL
dbb4369 
Signed-off-by: azjezz <azjezz@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

Assignees

@azjezz azjezz

Labels
Status: In Progress This issue is being worked on, and has someone assigned. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Add TLS/SSL support
3 participants
@azjezz @coveralls @veewee