Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Fix an option, cleanup typos & wording. #361

Merged
merged 5 commits into from
May 10, 2023
Merged

Conversation

Irets
Copy link
Contributor

@Irets Irets commented May 9, 2023

Fixed an option with a broken name (delete_allowded -> delete_allowed), various typos and improved wording in the configuration files.

The formatting was a bit weird as sometimes option names would start
"# option"
and sometimes
"#option"
but I didn't choose to act on those.

Compiled the project succesfully and found no run-time issues.

Copy link
Contributor Author

@Irets Irets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#ffmpeg = False # Set ffmpeg to True if you want to display DEBUG level log of ffmpeg.
#mumble_connection = False # Set to True if you need to debug mumble connection (pymumble lib)
#youtube_dl = False # Set to True if you need debug log from youtube-dl

I was confused why these options did not do anything 'till I removed the comments from ends of the options. (non-boolean values)
Currently you can enable options in this file by removing the preceeding '#' but not with this.
By placing the comments above the options, like with other options in this file, it becomes more intuitive to enable these options.

@azlux
Copy link
Owner

azlux commented May 10, 2023

Theses options activate some debug mode.
Globally, having default with lot of comment is good, but the example config become quite useless with time.

@azlux azlux merged commit e313d4e into azlux:master May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants