Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for review (again) #2

Open
azoff opened this issue Apr 6, 2014 · 1 comment
Open

Ready for review (again) #2

azoff opened this issue Apr 6, 2014 · 1 comment

Comments

@azoff
Copy link
Owner

azoff commented Apr 6, 2014

cc/ @nesquena @timothy1ee

gracias.

@timothy1ee
Copy link

Nice work! We added this homework so that you'll have the experience building an app that's more similar in complexity to a production app. It's also useful to have practical experience building a container view controller, which is a more advanced topic.

  • You might consider sharing some of the logic in AZUserTweetsController and AZHomeTimelineController.
  • Nice work with the profile page. Note that if you want the header to scroll with the tweets like the real Twitter app, then make it a tableHeaderView.
  • Nice work with the side menu controller. Check out this library for another way to design the side menu: https://github.com/mikefrederick/MFSideMenu.
  • There's something weird going on with your side menu. For some reason, after I switch to my profile view, all gestures stop working (scrolling the table view, hitting compose, opening the hamburger menu). Do you see that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants