Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/236/ongoing code maintenance #237

Merged
merged 6 commits into from Sep 26, 2020

Conversation

azriel91
Copy link
Owner

Closes #236.

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #237 into master will increase coverage by 0.61%.
The diff coverage is 41.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   68.69%   69.30%   +0.61%     
==========================================
  Files         649      649              
  Lines       22109    22628     +519     
==========================================
+ Hits        15187    15682     +495     
- Misses       6922     6946      +24     
Impacted Files Coverage Δ
...i_play/src/system/session_status_host_ui_system.rs 0.00% <0.00%> (ø)
crate/stdio_input/src/ion/splitter.rs 20.90% <0.00%> (+0.25%) ⬆️
...loading/src/ui_ascl/ui_ascl_character_selection.rs 0.00% <ø> (ø)
crate/wasm_support_fs/src/path_access_ext.rs 0.00% <0.00%> (ø)
...ading/src/system/collision_audio_loading_system.rs 50.79% <33.33%> (-3.90%) ⬇️
...udio_loading/src/system/ui_audio_loading_system.rs 51.66% <34.61%> (-2.44%) ⬇️
...rate/charge_play/src/system/charge_usage_system.rs 67.44% <100.00%> (-2.33%) ⬇️
crate/object_loading/src/object_loader.rs 48.38% <100.00%> (ø)
...e_play/src/system/frame_component_update_system.rs 63.63% <100.00%> (+2.52%) ⬆️
..._play/src/system/sequence_end_transition_system.rs 55.88% <100.00%> (-3.58%) ⬇️
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc9a09...7ca9709. Read the comment docs.

@azriel91 azriel91 merged commit 223f767 into master Sep 26, 2020
@azriel91 azriel91 deleted the maintenance/236/ongoing-code-maintenance branch September 26, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ongoing Code Maintenance
1 participant