Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EnsureOpSpec and CleanOpSpec with ApplyOpSpec. #99

Merged
merged 32 commits into from Mar 19, 2023

Conversation

azriel91
Copy link
Owner

Closes #67.

Note, EnsureCmd and CleanCmd will still exist, and delegate to ApplyCmd.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 91.76% and project coverage change: +0.17 🎉

Comparison is base (5c1c342) 93.29% compared to head (28d4b2b) 93.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   93.29%   93.47%   +0.17%     
==========================================
  Files         273      274       +1     
  Lines       20126    19957     -169     
==========================================
- Hits        18777    18654     -123     
+ Misses       1349     1303      -46     
Impacted Files Coverage Δ
crate/core/src/progress/progress_sender.rs 100.00% <ø> (ø)
crate/core/src/progress/progress_status.rs 100.00% <ø> (ø)
crate/core/src/progress/progress_tracker.rs 100.00% <ø> (ø)
crate/data/src/marker/current.rs 42.85% <ø> (ø)
crate/data/src/marker/desired.rs 42.85% <ø> (ø)
crate/resources/src/internal/states_mut.rs 100.00% <ø> (ø)
crate/resources/src/resources.rs 100.00% <ø> (ø)
crate/resources/src/resources/ts.rs 100.00% <ø> (ø)
crate/resources/src/states/states_saved.rs 100.00% <ø> (ø)
crate/rt_model/src/item_spec_boxed.rs 84.21% <ø> (ø)
... and 34 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Distinguish between `Current` and `ApplyDry` state markers.
@azriel91 azriel91 marked this pull request as ready for review March 19, 2023 03:31
@azriel91 azriel91 merged commit 52c2575 into main Mar 19, 2023
@azriel91 azriel91 deleted the feature/67/apply-op-spec branch March 19, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace EnsureOpSpec and CleanOpSpec with ApplyOpSpec
1 participant