Remove unnecessary sudo usage #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brk3
force-pushed
the
feature/pbourke-remove-sudo
branch
2 times, most recently
from
135d7ee
to
ab4e459
Compare
There are a number of random calls to sudo in scripts/tfstate_azurerm.sh. While rover runs in an isolated container it's still best to avoid unecessary privilege escalation where possible.
brk3
force-pushed
the
feature/pbourke-remove-sudo
branch
from
ab4e459
to
bceffab
Compare
|
Thanks for the PR @brk3. Closing this one as it has been refactored in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of random calls to sudo in
scripts/tfstate_azurerm.sh.
While rover runs in an isolated container it's still best to avoid
unecessary privilege escalation where possible.