Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance synapse to support defining multiple workspace_firewall #281

Closed
jleonelion opened this issue Feb 18, 2021 · 4 comments · Fixed by #363
Closed

Enhance synapse to support defining multiple workspace_firewall #281

jleonelion opened this issue Feb 18, 2021 · 4 comments · Fixed by #363
Assignees
Labels
enhancement New feature or request

Comments

@jleonelion
Copy link

Current implementation of aztfmod/caf/azurerm//modules/analytics/synapse only supports creating a single workspace_firewall rule. Request is to expand it to support defining multiple firewall rules.

Example:

settings = {
  ...
  workspace_firewalls = {
    rule1 = {
      name = "rule-whatever"
      start_ip = "10.0.0.1"
      end_ip = "10.0.100.0"
    }
  }
}
@jleonelion
Copy link
Author

assign to me and I can add

@jleonelion
Copy link
Author

@arnaudlh I have the changes made, but cannot commit them. I am running on Window 10 + VS Code, WSL, Docker using Rover as remote container, but get the below error about python3.6 when I perform commit

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
/usr/bin/env: ‘python3.6’: No such file or directory

@arnaudlh
Copy link
Member

@arnaudlh I have the changes made, but cannot commit them. I am running on Window 10 + VS Code, WSL, Docker using Rover as remote container, but get the below error about python3.6 when I perform commit

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
/usr/bin/env: ‘python3.6’: No such file or directory

hi @jleonelion, its an error due to precommit calls, will be fixed in next rover, in the meantime, just remove precommit using the precommit uninstall command!

jleonelion pushed a commit to jleonelion/terraform-azurerm-caf that referenced this issue Mar 28, 2021
@jleonelion
Copy link
Author

@LaurentLesle thank you for merging in my PR. Should I assume this issue stays open until those merged changes are included in a release of the CAF module?

@arnaudlh arnaudlh linked a pull request Apr 5, 2021 that will close this issue
@arnaudlh arnaudlh added this to To do in Milestone 2103 via automation Apr 5, 2021
@arnaudlh arnaudlh added the enhancement New feature or request label Apr 5, 2021
@arnaudlh arnaudlh moved this from To do to Done in Milestone 2103 Apr 5, 2021
BerendvW pushed a commit to VolkerWessels/terraform-azurerm-caf that referenced this issue Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants