Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic data sources #1068

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

a-ferri
Copy link

@a-ferri a-ferri commented Apr 4, 2022

Issue-id

PR Checklist


Description

In complement to the PR caf-terraform-landingzones/pull/349 for caf-terraform-landingzones module, we need a new variable here.
It will also merge additional data into the combined_objects locals.

This change aims to permit us to query resources not managed by CAF module so we can reference them through landing zone keys - the same we do with resources managed by CAF module.

Please refer to this PR for more information.

Does this introduce a breaking change

  • YES
  • NO

Testing

@a-ferri a-ferri marked this pull request as ready for review April 4, 2022 16:11
@LaurentLesle LaurentLesle added the enhancement New feature or request label Apr 12, 2022
@LaurentLesle LaurentLesle self-requested a review April 12, 2022 05:34
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the concept, will validate and integrate :)

Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks like a good way to reference existing object and reference them by their key

@arnaudlh arnaudlh added this to the 5.6.9 milestone Apr 28, 2023
@arnaudlh arnaudlh merged commit 51df510 into aztfmod:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants