Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk Encryption Set with CMK #296

Merged
merged 35 commits into from
Mar 25, 2021
Merged

Disk Encryption Set with CMK #296

merged 35 commits into from
Mar 25, 2021

Conversation

jorseng
Copy link
Collaborator

@jorseng jorseng commented Feb 26, 2021

Added disk_encryption_set module
Added access policy support for disk_encryption_set
Added support for vm os_disk with disk_encryption_set_id

@jorseng jorseng linked an issue Feb 26, 2021 that may be closed by this pull request
Managed Disk Encryption with Customer Managed Keys (CMK) #294
Closed
@jorseng jorseng changed the title Js encrypt disk cmk Disk Encryption Set with CMK Feb 26, 2021
arnaudlh
arnaudlh requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good contribution @jorseng can you please add examples and CI examples?

@jorseng
Copy link
Collaborator Author

jorseng commented Mar 3, 2021 •
edited

good contribution @jorseng can you please add examples and CI examples?

I have added configuration example to directory examples> virtual_machine > 212-vm-disk-encryption-set.
May I know the difference between examples vs CI examples?

@anamikanayal01
Copy link
Contributor

@arnaudlh @jorseng just updated the branch with Disk encryption set creation and assignment for os_disk and data_disk ; example folder 105 >Standalone for windows. I am working on the Linux VM so please dont approve the PR yet till i complete for linux vm.

@arnaudlh arnaudlh added the enhancement New feature or request label Mar 10, 2021
@arnaudlh arnaudlh added this to In progress in Milestone 2103 via automation Mar 23, 2021
Milestone 2103 automation moved this from In progress to Reviewer approved Mar 25, 2021
@arnaudlh arnaudlh merged commit fbbf064 into master Mar 25, 2021
Milestone 2103 automation moved this from Reviewer approved to Done Mar 25, 2021
@arnaudlh arnaudlh deleted the js-encrypt-disk-cmk branch March 25, 2021 03:51
@arnaudlh arnaudlh linked an issue Mar 25, 2021 that may be closed by this pull request
VM with CMK disk Encryption, Custom Image, Domain Join.... #248
Closed
BerendvW pushed a commit to VolkerWessels/terraform-azurerm-caf that referenced this pull request Jun 21, 2023
@arnaudlh
Merge pull request aztfmod#296 from hantonelli/patch-1
e5a7640 
Add domain_name_registrations to local.remote.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

@anamikanayal01 anamikanayal01 Awaiting requested review from anamikanayal01

@LaurentLesle LaurentLesle Awaiting requested review from LaurentLesle

Assignees

@anamikanayal01 anamikanayal01

Labels
enhancement New feature or request
Projects
No open projects
Milestone 2103
Done
Milestone
No milestone
4 participants
@jorseng @anamikanayal01 @arnaudlh @LaurentLesle