Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance sqldb module to create db user for managed identity #339

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

jorseng
Copy link
Collaborator

@jorseng jorseng commented Mar 17, 2021

PR for Issue #334

@jorseng jorseng requested a review from arnaudlh March 17, 2021 14:59
@jorseng jorseng self-assigned this Mar 17, 2021
@arnaudlh arnaudlh changed the base branch from master to integration-sql1 March 18, 2021 03:21
@arnaudlh arnaudlh changed the base branch from integration-sql1 to master March 18, 2021 03:22
@jorseng
Copy link
Collaborator Author

jorseng commented Mar 18, 2021

@arnaudlh , the one error does not seems to be related to the module itself, how to proceed for this error?

@arnaudlh arnaudlh added this to In progress in Milestone 2103 via automation Mar 19, 2021
@arnaudlh arnaudlh changed the title enhance sqldb module to create db user for managed identity Enhance sqldb module to create db user for managed identity Mar 19, 2021
@arnaudlh arnaudlh added the enhancement New feature or request label Mar 19, 2021
Milestone 2103 automation moved this from In progress to Reviewer approved Mar 19, 2021
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh mentioned this pull request Mar 19, 2021
10 tasks
@arnaudlh arnaudlh merged commit e57ec11 into master Mar 19, 2021
Milestone 2103 automation moved this from Reviewer approved to Done Mar 19, 2021
@arnaudlh arnaudlh deleted the js-mssql-db-mi branch March 19, 2021 13:51
BerendvW pushed a commit to VolkerWessels/terraform-azurerm-caf that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

mssql_database enhancement to create database user for AAD managed identity
3 participants