Feature/657- Module for creating storage account management policy #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 27, 2021 19:24
This module contains all the code needed for storage account management.
Terraform is not clear on which blocks/parameters are optional. Action is not optional, but I made everything else optional.
|
This PR is not ready, please do not merge. I have found a bug that needs to be resolved. |
|
Bug resolved. I had commented out the code that validated whether or not a |
arnaudlh
approved these changes
Sep 14, 2021
|
Looks good to me, in a future version, we probably want to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This module contains all the code needed for the storage account management policy. A few notes:
Code Structure
management_policiesblock since users can only have onemanagement_policy(modules/storage_account/storage_account.tf).dynamicblock. For example, inexamples/storage_accounts/107-storage-account-management-policy/configuration.tfvars, line 51, 52:base_blob, but inmodules/storage_account/management_policy/management_policy.tflines 31 and 32, I am unable to use the dynamic block to validate thatbase_blobexists and loop through it. Therefore I must have a buffer calledblob_specs.