Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Digital Twins #910

Merged
merged 8 commits into from
Apr 25, 2022

Conversation

rfernandezdo
Copy link
Contributor

@rfernandezdo rfernandezdo commented Jan 27, 2022

Submodule digital twins
Modules for:
azurerm_digital_twins_endpoint_eventgrid
azurerm_digital_twins_endpoint_eventhub
azurerm_digital_twins_endpoint_servicebus
azurerm_digital_twins_instance

Related:
aztfmod/terraform-provider-azurecaf#151
#918

@rfernandezdo rfernandezdo changed the title [WIP] Submodulue digital twins [WIP] Submodule digital twins Jan 27, 2022
@rfernandezdo rfernandezdo marked this pull request as ready for review February 3, 2022 11:46
@rfernandezdo rfernandezdo changed the title [WIP] Submodule digital twins Submodule digital twins Feb 3, 2022
@arnaudlh arnaudlh added this to In progress in Milestone 2202 Feb 4, 2022
@arnaudlh arnaudlh changed the title Submodule digital twins Adding support for Digital Twins Feb 22, 2022
@arnaudlh
Copy link
Member

Looks good, will be pending event grid.

@arnaudlh arnaudlh changed the base branch from main to AL-azurerm2931 February 28, 2022 09:58
@arnaudlh arnaudlh added this to In progress in Milestone 2203 via automation Mar 1, 2022
@arnaudlh arnaudlh removed this from In progress in Milestone 2202 Mar 1, 2022
@arnaudlh arnaudlh removed this from In progress in Milestone 2203 Apr 6, 2022
@arnaudlh arnaudlh added this to In progress in Milestone 2204 via automation Apr 6, 2022
@arnaudlh arnaudlh added this to the 5.6.0 milestone Apr 6, 2022
@arnaudlh arnaudlh changed the base branch from AL-azurerm2931 to int-5.6.0 April 25, 2022 07:20
@arnaudlh arnaudlh added iot and removed do not merge labels Apr 25, 2022
Milestone 2204 automation moved this from In progress to Reviewer approved Apr 25, 2022
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of updates Ill be adding at merge time.

@arnaudlh
Copy link
Member

thanks for your contribution to CAF @rfernandezdo

@arnaudlh arnaudlh merged commit 92ee1ac into aztfmod:int-5.6.0 Apr 25, 2022
Milestone 2204 automation moved this from Reviewer approved to Done Apr 25, 2022
@rfernandezdo
Copy link
Contributor Author

Thanks to you, without your work my contribution could not have been made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants