Skip to content

Commit

Permalink
Merge pull request #243 from blinqas/add-support-for-new-web-apps
Browse files Browse the repository at this point in the history
Add support for azurerm_linux_web_app and azurerm_windows_web_app
  • Loading branch information
arnaudlh committed Jun 23, 2023
2 parents 7ef0650 + 1f0b32c commit 75b62ef
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Please, find below the steps that should be followed to contribute:

4. Choose the slug for the resource

Every resource in CAF does have a slug that associate with this resource this is 2 to 5 letters that identify that resource, for example, the slug for a `key vault` is `kv` for a storage account `st` What is important here it is to try to keep this short but meaningful and avoid collision with existing ones. Don't worry about knowing all existing ones if you choose one that exists already the tests will fail.
Every resource in CAF does have a slug that associate with this resource this is 2 to 5 letters that identify that resource, for example, the slug for a `key vault` is `kv` for a storage account `st` What is important here it is to try to keep this short but meaningful and avoid collision with existing ones. Don't worry about knowing all existing ones if you choose one that exists already the tests will fail. You can also check if the resource has a example abbreviation on this page: [doc](https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations)

5. Modify the `resourceDefinition.json`

Expand Down
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,8 @@ This is the current compreheensive status of the implemented resources in the pr
|azurerm_lighthouse_definition ||
|azurerm_linux_virtual_machine ||
|azurerm_linux_virtual_machine_scale_set ||
|azurerm_linux_web_app ||
|azurerm_linux_web_app_slot ||
|azurerm_local_network_gateway ||
|azurerm_log_analytics_cluster ||
|azurerm_log_analytics_cluster_customer_managed_key ||
Expand Down Expand Up @@ -753,6 +755,9 @@ This is the current compreheensive status of the implemented resources in the pr
|azurerm_web_pubsub_hub ||
|azurerm_windows_virtual_machine ||
|azurerm_windows_virtual_machine_scale_set ||
|azurerm_windows_web_app ||
|azurerm_windows_web_app_slot ||


❌ = Not yet implemented
✔ = Already implemented
Expand Down
6 changes: 5 additions & 1 deletion azurecaf/models_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions resourceDefinition.json
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,17 @@
"lowercase": false,
"regex": "\"[\\\\/\\\"\\\\[\\\\]:|<>+=;,?*@&_]\""
},
{
"name": "azurerm_linux_web_app",
"min_length": 2,
"max_length": 60,
"validation_regex": "\"^[0-9A-Za-z][0-9A-Za-z-]{0,58}[0-9a-zA-Z]$\"",
"scope": "global",
"slug": "lwapp",
"dashes": true,
"lowercase": false,
"regex": "\"[^0-9A-Za-z-]\""
},
{
"name": "azurerm_managed_disk",
"min_length": 1,
Expand Down Expand Up @@ -638,6 +649,17 @@
"lowercase": false,
"regex": "\"[\\\\/\\\"\\\\[\\\\]:|<>+=;,?*@&_]\""
},
{
"name": "azurerm_windows_web_app",
"min_length": 2,
"max_length": 60,
"validation_regex": "\"^[0-9A-Za-z][0-9A-Za-z-]{0,58}[0-9a-zA-Z]$\"",
"scope": "global",
"slug": "wwapp",
"dashes": true,
"lowercase": false,
"regex": "\"[^0-9A-Za-z-]\""
},
{
"name": "azurerm_consumption_budget_resource_group",
"min_length": 1,
Expand Down

0 comments on commit 75b62ef

Please sign in to comment.