Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Azure Log Analytics Cluster (Dedicated Cluster) #239

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Add support for Azure Log Analytics Cluster (Dedicated Cluster) #239

merged 2 commits into from
Jun 23, 2023

Conversation

BlauerPulli
Copy link

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BlauerPulli
Copy link
Author

BlauerPulli commented May 17, 2023 •
edited

@LaurentLesle can you add an exception in sonarqube for this finding?

@BlauerPulli
Copy link
Author

@LaurentLesle is anything missing which prevents the merge?

@arnaudlh arnaudlh added this to the 1.2.26 milestone Jun 23, 2023
@arnaudlh arnaudlh added the enhancement New feature or request label Jun 23, 2023
@arnaudlh arnaudlh linked an issue Jun 23, 2023 that may be closed by this pull request
Add support for Log Analytics Dedicated Cluster #232
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnaudlh arnaudlh merged commit 410acf1 into aztfmod:main Jun 23, 2023
3 checks passed
@arnaudlh
Copy link
Member

thanks for the PR @BlauerPulli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

Assignees

@BlauerPulli BlauerPulli

Labels
enhancement New feature or request
Projects
2306
Status: ✅ Done
Milestone
1.2.26
Development

Successfully merging this pull request may close these issues.

Add support for Log Analytics Dedicated Cluster
3 participants
@BlauerPulli @arnaudlh @LaurentLesle