Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azurerm_monitor_data_collection_endpoint #256

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add azurerm_monitor_data_collection_endpoint #256

merged 3 commits into from
Jan 11, 2024

Conversation

Hlosani-M
Copy link
Contributor

@Hlosani-M Hlosani-M commented Oct 3, 2023 •
edited

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnaudlh arnaudlh self-requested a review January 11, 2024 03:13
@arnaudlh arnaudlh added the enhancement New feature or request label Jan 11, 2024
@arnaudlh arnaudlh changed the title Adding azurerm_monitor_data_collection_endpoint Add azurerm_monitor_data_collection_endpoint Jan 11, 2024
@arnaudlh arnaudlh linked an issue Jan 11, 2024 that may be closed by this pull request
Add support for azurerm_monitor_data_collection_endpoint resource. #255
Closed
@arnaudlh arnaudlh added this to the 1.2.27 milestone Jan 11, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

arnaudlh
arnaudlh approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit a9796bc into aztfmod:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@Hlosani-M Hlosani-M

Labels
enhancement New feature or request
Projects
2401
Status: Done
Milestone
1.2.27
Development

Successfully merging this pull request may close these issues.

Add support for azurerm_monitor_data_collection_endpoint resource.
2 participants
@Hlosani-M @arnaudlh