Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a resource for Azure Open AI Deployment and example how to use it. #279

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Added a resource for Azure Open AI Deployment and example how to use it. #279

merged 2 commits into from
Apr 10, 2024

Conversation

bbmilan
Copy link
Contributor

@bbmilan bbmilan commented Mar 19, 2024 •
edited
Loading

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@bbmilan bbmilan closed this Mar 19, 2024
@bbmilan bbmilan reopened this Mar 19, 2024
@arnaudlh arnaudlh self-requested a review April 5, 2024 00:59
@arnaudlh arnaudlh added the enhancement New feature or request label Apr 5, 2024
@arnaudlh arnaudlh added this to the 1.2.29 milestone Apr 10, 2024
arnaudlh
arnaudlh approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bbmilan
bbmilan commented Apr 10, 2024
View reviewed changes
Copy link
Contributor Author

@bbmilan bbmilan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it hasn't merged changes into the main branch.

@Nepomuceno Nepomuceno merged commit 1a5a959 into aztfmod:main Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nepomuceno Nepomuceno Nepomuceno approved these changes

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@bbmilan bbmilan

Labels
enhancement New feature or request
Projects
2404
Status: Done
Milestone
1.2.29
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbmilan @Nepomuceno @arnaudlh