Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): fetch with credentials for same origin request #7

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

yaeda
Copy link
Collaborator

@yaeda yaeda commented Feb 26, 2018

When the plugin option is private: true and the document site has authentication, fetching local contents doesn't work. I added { credential: "same-origin" } to fetch local contents.

Sorry for my frequent PRs. Should I have created a new plugin myself 😕 ?

@azu azu merged commit 580e88c into azu:master Feb 26, 2018
@azu
Copy link
Owner

azu commented Feb 26, 2018

Sorry for my frequent PRs. Should I have created a new plugin myself 😕 ?

No problem.
I've invited @yaeda as collaborators in this repository.
Also, I've added to npm too 😃

Feel free to develop this plugin!
Of course, I will review if necessary.
(Feel free to assign Reviewers)

@azu
Copy link
Owner

azu commented Feb 26, 2018

Relase 1.3.2

Publish log
npm test # but this plugin have not test yet
npm version patch
npm publish

@yaeda
Copy link
Collaborator Author

yaeda commented Feb 26, 2018

Wow, Thank you very much for the invitation. I accepted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants