fix(indexeddb): remove "debug" option (#25)

* fix(indexeddb): remove "debug" option This options is for debugging. Remove it, but it does not change behavior * Update README
azu · Mar 2, 2022 · 606b9a2 · 606b9a2
1 parent d9bbeca
commit 606b9a2
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 30 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,13 +12,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [12]
-        os: [ubuntu-18.04]
+        node-version: [12,14,16]
+        os: [ubuntu-latest]
     steps:
       - name: checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ KVS libraries provide following common features.
 ## Support Browsers
 
 - A browser that support [AsyncIterator](https://caniuse.com/#feat=mdn-javascript_builtins_symbol_asynciterator)
-- Chromium-based MSEdge, Chrome, Firefox, macOS Safari
+- Chromium-based(Google Chrome and MSEdge), Firefox, and macOS Safari
 
 ## Packages
 

diff --git a/packages/env/test/node.test.ts b/packages/env/test/node.test.ts
@@ -7,8 +7,7 @@ const kvsTestCase = createKVSTestCase(
     (options) =>
         kvsEnvStorage({
             name: databaseName,
-            ...options,
-            debug: true
+            ...options
         }),
     {
         setTestDataList: [

diff --git a/packages/indexeddb/src/index.ts b/packages/indexeddb/src/index.ts
@@ -8,15 +8,6 @@ function invariant(condition: any, message: string): asserts condition {
     throw new Error(message);
 }
 
-const debug = {
-    enabled: false,
-    log(...args: any[]) {
-        if (!debug.enabled) {
-            return;
-        }
-        console.log(...args);
-    }
-};
 const openDB = ({
     name,
     version,
@@ -91,11 +82,9 @@ const dropInstance = (database: IDBDatabase, databaseName: string): Promise<void
             resolve();
         };
         request.onblocked = () => {
-            debug.log("dropInstance:blocked", request);
             reject(request.error);
         };
         request.onerror = function () {
-            debug.log("dropInstance:error", request);
             reject(request.error);
         };
         request.onsuccess = function () {
@@ -243,7 +232,6 @@ const iterator = <Schema extends KVSIndexedSchema, K extends StoreNames<Schema>,
 
 type IndexedDBOptions = {
     tableName?: string;
-    debug?: boolean;
 };
 type IndexedDBResults = {
     dropInstance(): Promise<void>;
@@ -304,9 +292,6 @@ export const kvsIndexedDB = async <Schema extends KVSIndexedSchema>(
     const { name, version, upgrade, ...indexDBOptions } = options;
     invariant(typeof name === "string", "name should be string");
     invariant(typeof version === "number", "version should be number");
-    if (indexDBOptions.debug) {
-        debug.enabled = indexDBOptions.debug;
-    }
     const tableName = indexDBOptions.tableName ?? "kvs";
     const database = await openDB({
         name,

diff --git a/packages/indexeddb/test/index.test.ts b/packages/indexeddb/test/index.test.ts
@@ -7,8 +7,7 @@ const kvsTestCase = createKVSTestCase(
     (options) =>
         kvsIndexedDB({
             name: databaseName,
-            ...options,
-            debug: true
+            ...options
         }),
     {
         setTestDataList: [

diff --git a/packages/localstorage/test/index.test.ts b/packages/localstorage/test/index.test.ts
@@ -6,8 +6,7 @@ const kvsTestCase = createKVSTestCase(
     (options) =>
         kvsLocalStorage({
             name: databaseName,
-            ...options,
-            debug: true
+            ...options
         }),
     {
         setTestDataList: [

diff --git a/packages/memorystorage/test/index.test.ts b/packages/memorystorage/test/index.test.ts
@@ -6,8 +6,7 @@ const kvsTestCase = createKVSTestCase(
     (options) =>
         kvsMemoryStorage({
             name: databaseName,
-            ...options,
-            debug: true
+            ...options
         }),
     {
         setTestDataList: [

diff --git a/packages/node-localstorage/test/index.test.ts b/packages/node-localstorage/test/index.test.ts
@@ -6,8 +6,7 @@ const kvsTestCase = createKVSTestCase(
     (options) =>
         kvsLocalStorage({
             name: databaseName,
-            ...options,
-            debug: true
+            ...options
         }),
     {
         setTestDataList: [