Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node version in github workflow is not correctly set #21

Closed
tilap opened this issue Aug 14, 2020 · 0 comments
Closed

Node version in github workflow is not correctly set #21

tilap opened this issue Aug 14, 2020 · 0 comments

Comments

@tilap
Copy link

tilap commented Aug 14, 2020

Hi. Thanks for this great repo !

There is a misspell in the github workflow publish.yml. The action actions/setup-node@v1 set the node version with node-version and not node_version (otherwise, it the the v10.X).

      - name: Setup Node.js
        uses: actions/setup-node@v1
        with:
          node-version: 12 # <-- this line
          registry-url: 'https://npm.pkg.github.com'

Have a nice day!

@azu azu closed this as completed in b7a9a62 Nov 10, 2020
azu added a commit that referenced this issue Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant