Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency jquery to v3 - autoclosed #3

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jul 5, 2019

This PR contains the following updates:

Package Type Update Change
jquery (source) dependencies major ^1.0.0 -> ^3.0.0

GitHub Vulnerability Alerts

CVE-2015-9251

jQuery before 3.0.0 is vulnerable to Cross-site Scripting (XSS) attacks when a cross-domain Ajax request is performed without the dataType option, causing text/javascript responses to be executed.

CVE-2019-11358

jQuery before 3.4.0, as used in Drupal, Backdrop CMS, and other products, mishandles jQuery.extend(true, {}, ...) because of Object.prototype pollution. If an unsanitized source object contained an enumerable proto property, it could extend the native Object.prototype.


Release Notes

jquery/jquery

v3.4.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the security label Jul 5, 2019
@renovate renovate bot assigned azu Jul 5, 2019
@azu azu changed the title Update dependency jquery to v3 rebase! Update dependency jquery to v3 Jul 5, 2019
@renovate renovate bot force-pushed the renovate/npm-jquery-vulnerability branch from b210296 to 3100bc4 Compare July 5, 2019 07:22
@renovate renovate bot changed the title rebase! Update dependency jquery to v3 Update dependency jquery to v3 Jul 5, 2019
@@ -38,7 +38,7 @@
"homepage": "https://github.com/azu/immutable-array-prototype/tree/master/packages/copy-within/",
"dependencies": {
"@immutable-array/internal": "^1.0.4",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは npm registry には存在しないパッケージ。
lerna + npm だとlernaのロジックで解決してる。
なので、packge-lockには含まれない

@azu
Copy link
Owner

azu commented Jul 5, 2019

npm + lerna + renovatebot work fine

@renovate renovate bot force-pushed the renovate/npm-jquery-vulnerability branch from 3100bc4 to 4b83a81 Compare July 5, 2019 08:05
@renovate renovate bot changed the title Update dependency jquery to v3 Update dependency jquery to v3 [SECURITY] Jul 5, 2019
@azu azu changed the title Update dependency jquery to v3 [SECURITY] Update dependency jquery to v3 Jul 12, 2019
@azu azu changed the title Update dependency jquery to v3 Update dependency jquery to v3 - autoclosed Jul 12, 2019
@azu azu closed this Jul 12, 2019
@azu azu deleted the renovate/npm-jquery-vulnerability branch July 12, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants