refactor: spreadsheet/get prepare for future schema #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
changed the title
azu
commented
Mar 20, 2021
| throw new Error("statsRow is not defined"); | ||
| } | ||
| const README = statsRow?.values?.[3]?.formattedValue! ?? ""; | ||
| // TODO: stats should be different by year |
There was a problem hiding this comment.
Currently, the "budget" sheet is not defined yet.
| { | ||
| year: currentYear, | ||
| stats, | ||
| README, |
There was a problem hiding this comment.
README will be moved to top-level?
| @@ -5,9 +5,11 @@ | |||
| "scripts": { | |||
| "dev": "npm-run-all -p dev:next", | |||
| "dev:next": "next --port 3000", | |||
| "dev:prod": "ENABLE_PRODUCTION_DATA=1 next --port 3000", | |||
There was a problem hiding this comment.
start with production data.
It is useful for debug.
azu
commented
Mar 20, 2021
| export const TEST_SPREADSHEET_URL = | ||
| "https://docs.google.com/spreadsheets/d/1gmVOU7Zi_g6fV7aWPUnZhgKLd5EdltxeWbwlufM3Plc/edit"; | ||
| export const hasTestCredential = () => { | ||
| return Boolean(process.env.TEST_GOOGLE_CREDENTIAL_BASE64); |
There was a problem hiding this comment.
TEST_GOOGLE_CREDENTIAL_BASE64 is just base64 of credentials object.
azu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/spreadsheet/getsupport next records schema Definition of SpreadSheet Schema #22