Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getURLのresolveを2xx全体を扱うように変更する #310

Closed
azu opened this issue Jul 27, 2019 · 2 comments · Fixed by #314
Closed

getURLのresolveを2xx全体を扱うように変更する #310

azu opened this issue Jul 27, 2019 · 2 comments · Fixed by #314
Labels
Type: Feature New Feature
Milestone
2.0.0

Comments

@azu
Copy link
Owner

azu commented Jul 27, 2019

200 限定にしているのは良くないので、 https://fetch.spec.whatwg.org/#ok-status に合わせて 20x 系にする
@azu
Copy link
Owner Author

azu commented Jul 27, 2019

#295 と関係

@azu azu added the Type: Feature New Feature label Jul 27, 2019
@azu azu added this to the 2.0.0 milestone Jul 27, 2019
@azu azu mentioned this issue Jul 27, 2019
Closed
13 tasks
@azu
Copy link
Owner Author

azu commented Aug 24, 2019

いっそfetchURLにするか

@azu azu mentioned this issue Aug 24, 2019
Merged
@azu azu closed this as completed in #314 Aug 24, 2019
@azu azu mentioned this issue Oct 21, 2019
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature New Feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

refactor: getURL -> fetchURLに変更 azu/promises-book
1 participant
@azu