Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements/fixes #12

Open
ghost opened this issue Oct 31, 2021 · 6 comments
Open

Some improvements/fixes #12

ghost opened this issue Oct 31, 2021 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Oct 31, 2021

1-FIXED-#13.

Look at the output. There's a useless newline. I have no exclusive/special knowledge in Rust, so I don't know the various macros in the program. I think there could be a fix.
image
It happens here too.
2.
How about displaying the profile picture on the left of the box? Looks like the viuer crate could do the job.
3.
image
This never happens if the terminal size is sufficient, but when the terminal is small, the output becomes garbled in a very unfashionable way. Neofetch solves the problem by detecting the terminal size and cutting the output. Looks like https://docs.rs/term_size/0.3.2/term_size/ could help you out.

@azur1s
Copy link
Owner

azur1s commented Oct 31, 2021

there is a hardcoded spacing for the terminal box, maybe that is what caused the # 3 problems, other than that ill try to look into it

@azur1s azur1s added bug Something isn't working good first issue Good for newcomers labels Oct 31, 2021
@azur1s
Copy link
Owner

azur1s commented Oct 31, 2021

I dont think the 1-2 issue should be a big problems though, neofetch also have it and it is in bash iirc, How about add a new line at the start to balance it out? Maybe if we cant hide it maybe we could just embrace it? :D

@ghost
Copy link
Author

ghost commented Oct 31, 2021

I dont think the 1-2 issue should be a big problems though, neofetch also have it and it is in bash iirc, How about add a new line at the start to balance it out? Maybe if we cant hide it maybe we could just embrace it? :D

If you said that to Linus, he would've ranted like crazy tho
anyways I think adding an xtra newline at the top would make sense too

@ghost
Copy link
Author

ghost commented Oct 31, 2021

there is a hardcoded spacing for the terminal box, maybe that is what caused the # 3 problems, other than that ill try to look into it

Save the variable using the term_size function and use it in let dashes = "─".repeat(self.longest_line + 3 - 18); somehow, I don't know Rust-specific stuff

@azur1s
Copy link
Owner

azur1s commented Oct 31, 2021

I dont remember what the - 18 is for, but it solved my problems earlier. Maybe ill try to get term size and use in the math itself

Geoxor added a commit that referenced this issue Oct 31, 2021
fixes new line issue mentioned in #12
@azur1s
Copy link
Owner

azur1s commented Oct 31, 2021

for the - 18: i think the push functions also counts the main_color and accent_color into its length too, thats why i use -18 to deduct it out, i think its also works like that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant