Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop when signing-in with a guest account in a single tenant application #30

Closed
jmprieur opened this issue Dec 8, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@jmprieur
Copy link
Contributor

jmprieur commented Dec 8, 2018

This issue is for a: (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

  1. Change the appsetttings.json to set tenantId to a GUID (to have a tenanted authority). This only reproes with a single tenant app
  2. sign-in to the app with a guest user
  3. try to call Contact

Any log messages given by the failure

There is an infinite loop

Expected/desired behavior

you can see the information about the signed-in user

OS and Version?

Chrome

Versions

Mention any other details that might be useful

When calling the controller, the cache is empty. This is because the cache is keyed by the MSAL.id, and the computation of the MSAL.id is not right in the case of a guest user (tid and iod are the guest ones, not the home tenant information).

@jmprieur jmprieur added the bug Something isn't working label Dec 8, 2018
@jmprieur jmprieur changed the title GetMsalAccountId does not retrieve the right value for guest users in sigle tenant apps Infinite loop when signing-in with a guest account in a single tenant application Dec 10, 2018
@jmprieur
Copy link
Contributor Author

For the moment, fixed the issue with special processing for guest users
however.
GetMsalAccountId does not retrieve the right value for guest users in sigle tenant apps. Getting the home tenant id and home oid would require one more call to the STS.

@antonGritsenko
Copy link

Looks like it returns, see referenced issue above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants