[eslint-plugin] enable no-only-tests, import and tsdoc plugins for fl…

…at config (Azure#29791)

with the help of  @eslint/compat

common/tools/eslint-plugin-azure-sdk-helper/package.json

@@ -16,6 +16,7 @@
   },
   "dependencies": {
     "@azure/eslint-plugin-azure-sdk": "^3.1.0",
+    "@eslint/compat": "^1.0.1",
     "@eslint/js": "~9.2.0",
     "@typescript-eslint/typescript-estree": "~7.10.0",
     "@types/eslint": "~8.56.10",

common/tools/eslint-plugin-azure-sdk/package.json

@@ -71,6 +71,7 @@
     "eslint-plugin-markdown": "^5.0.0"
   },
   "dependencies": {
+    "@eslint/compat": "^1.0.1",
     "@eslint/js": "~9.2.0",
     "@typescript-eslint/typescript-estree": "~7.10.0",
     "@types/eslint": "~8.56.10",

common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-base.ts

@@ -42,15 +42,14 @@ export default {
         curly: ["error", "multi-line"],
         "eol-last": ["error", "always"],
         eqeqeq: ["error", "always", { null: "ignore" }],
-        // https://github.com/import-js/eslint-plugin-import/issues/2948
-        // "import/no-extraneous-dependencies": [
-        //   "error",
-        //   {
-        //     devDependencies: ["test/**/*.ts", "samples/**", "**/karma.conf.js", "**/.eslintrc.js"],
-        //     optionalDependencies: false,
-        //     peerDependencies: false,
-        //   },
-        // ],
+        "import/no-extraneous-dependencies": [
+          "error",
+          {
+            devDependencies: ["test/**/*.ts", "samples/**", "**/karma.conf.js", "**/.eslintrc.js"],
+            optionalDependencies: false,
+            peerDependencies: false,
+          },
+        ],
         "no-console": "off",
         "no-dupe-class-members": "off",
         "no-invalid-this": "off",

common/tools/eslint-plugin-azure-sdk/src/configs/azure-sdk-customized.ts

@@ -2,6 +2,10 @@
 // Licensed under the MIT license.
 
 import type { FlatConfig, SharedConfig } from "@typescript-eslint/utils/ts-eslint";
+import { fixupPluginRules } from "@eslint/compat";
+import noOnlyTests from "eslint-plugin-no-only-tests";
+import tsdoc from "eslint-plugin-tsdoc";
+import { rules as importRules } from "eslint-plugin-import";
 
 const tsEslintCustomization: Record<string, SharedConfig.RuleEntry> = {
   "@typescript-eslint/no-invalid-this": "off",
@@ -101,6 +105,37 @@ const azsdkDefault: Record<string, SharedConfig.RuleEntry> = {
   "@azure/azure-sdk/ts-doc-internal": "off",
 };
 
+const noOnlyTestsCustomization = {
+  name: "no-only-tests-azsdk-customized",
+  plugins: {
+    "no-only-tests": fixupPluginRules(noOnlyTests),
+  },
+  files: ["**/test/**/*.ts"],
+  rules: {
+    "no-only-tests/no-only-tests": "error",
+  },
+};
+
+const tsdocCustomization = {
+  name: "tsdoc-azsdk-customized",
+  plugins: {
+    tsdoc: fixupPluginRules(tsdoc),
+  },
+  rules: {
+    "tsdoc/syntax": "error",
+  },
+};
+
+const importCustomization = {
+  name: "import-azsdk-customized",
+  plugins: {
+    import: fixupPluginRules({ rules: importRules }),
+  },
+  rules: {
+    "import/no-extraneous-dependencies": "error",
+  },
+};
+
 const rules: Record<string, SharedConfig.RuleEntry> = {
   ...tsEslintCustomization,
   ...azsdkDefault,
@@ -141,4 +176,7 @@ export default (parser: FlatConfig.Parser): FlatConfig.ConfigArray => [
       main: "src/index.ts",
     },
   },
+  noOnlyTestsCustomization as FlatConfig.Config,
+  tsdocCustomization as FlatConfig.Config,
+  importCustomization as FlatConfig.Config,
 ];

common/tools/eslint-plugin-azure-sdk/src/typings/eslint-plugin-import.d.ts

@@ -0,0 +1,6 @@
+declare module 'eslint-plugin-import' {
+  import type { FixupPluginDefinition } from '@eslint/compat';
+
+  declare const exprt: FixupPluginDefinition;
+  export = exprt;
+}

common/tools/eslint-plugin-azure-sdk/src/typings/eslint-plugin-no-only-tests.d.ts

@@ -0,0 +1,6 @@
+declare module 'eslint-plugin-no-only-tests' {
+  import type { FixupPluginDefinition } from '@eslint/compat';
+
+  declare const exprt: FixupPluginDefinition;
+  export = exprt;
+}

sdk/cosmosdb/cosmos/eslint.config.mjs

@@ -28,9 +28,8 @@ export default [
       "@azure/azure-sdk/ts-package-json-module": "warn",
       "@azure/azure-sdk/ts-doc-internal": "warn",
 
-      // not supporting flag config yet https://github.com/import-js/eslint-plugin-import/issues/2948
       // https://github.com/benmosher/eslint-plugin-import/issues/1816
-      // "import/no-extraneous-dependencies": "off",
+      "import/no-extraneous-dependencies": "off",
     },
   },
 ];