Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreCLR implementation #43

Closed
stephanjohnson opened this issue Nov 1, 2015 · 4 comments · Fixed by #78
Closed

CoreCLR implementation #43

stephanjohnson opened this issue Nov 1, 2015 · 4 comments · Fixed by #78
Assignees

Comments

@stephanjohnson
Copy link

When can we expect to have this library implemented for CoreCLR?

@xinchen10 xinchen10 self-assigned this Nov 18, 2015
xinchen10 added a commit that referenced this issue Dec 7, 2015
#43 Support CoreCLR and dotnet target
@fsoikin
Copy link
Contributor

fsoikin commented Dec 21, 2015

I've managed to get it running on CoreCLR rc1-update1 (and on rc2 as well, barring issue aspnet/dnx#3271)

I had to do three changes for this:

  1. In project.json change the target from dotnet to dnxcore50, otherwise dnx refuses to load the library. I'm not quite sure whether dotnet is now deprecated altogether or if something else was missing. Haven't gotten around to figuring that out yet.
  2. In project.json add the SRAmqp.resx file as namedResource. It seems this file is only required for error reporting though. When everything is ok, its absence is not noticeable, but whenever anything goes wrong, you get a "resource not found" error.
  3. Stop using the Socket.BeginX/EndX methods and rewrite the corresponding tasks in terms of Socket.XAsync, because the former have been removed from the Socket contract in coreclr as of RC1.

My changes are here: fsoikin@c1a000f
Would you be interested in a pull request?

@xinchen10
Copy link
Member

@fsoikin it would be great if you can send a PR. Just a question about item 1: is it a must to replace dotnet with dnxcore50? I read a few online posts about the new way to target frameworks and it is recommended to use dotnet if the library works on any platform as long as the dependencies are met.

@fsoikin
Copy link
Contributor

fsoikin commented Jan 4, 2016

I have read those posts, too, and tried dotnet first, and unfortunately, it doesn't work.

I hesitate to file an issue with the CoreCLR team yet, because they seems to be in the process of tossing these things around a bit. I will check back on this once they hit RTM.

@fsoikin fsoikin mentioned this issue Jan 4, 2016
@fsoikin
Copy link
Contributor

fsoikin commented Jan 4, 2016

Created a PR.
My contributor agreement is already signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants