Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from dep to Go modules #3

Closed
jim-minter opened this issue Dec 17, 2019 · 4 comments · Fixed by #972
Closed

Move from dep to Go modules #3

jim-minter opened this issue Dec 17, 2019 · 4 comments · Fixed by #972
Labels
blocked Issue or pull request is blocked priority-low Low priority issue or pull request size-medium Size medium

Comments

@jim-minter
Copy link
Member

jim-minter commented Dec 17, 2019 •
edited
Loading

jim-minter/rp#4
@jim-minter
Copy link
Member Author

Currently blocked because https://github.com/openshift/installer's nested vendor directories break go mod.

@jim-minter jim-minter added blocked Issue or pull request is blocked priority-low Low priority issue or pull request labels Dec 17, 2019
@jim-minter jim-minter added the size-medium Size medium label Jan 11, 2020
@mjudeikis
Copy link
Contributor

mjudeikis commented Jan 22, 2020 •
edited
Loading

main repositories are moving to the right direction too:
openshift/api#456

@mjudeikis
Copy link
Contributor

openshift/installer#2745
This would enable ARO to use go modules

jim-minter pushed a commit that referenced this issue Jan 28, 2020
@julienstroheker
Juliens/az pipelines fix (#3)
735cb62 
* apply review

* test vars

* python and golang fix

* using vendor bin

* fix and clean
pkoushik pushed a commit to pkoushik/ARO-RP that referenced this issue Apr 24, 2020
@Zhuoli
Inte2e (Azure#3)
c6e5410 
* Wait for 6 hours before calling billing e2e
* Use builddefinition ID instead of builddefinition name
* Use var parameters in TriggerBuild
pkoushik pushed a commit to pkoushik/ARO-RP that referenced this issue Apr 24, 2020
@Zhuoli
Revert "Inte2e (Azure#3)"
7c164b6 
This reverts commit c6e5410.
@olga-mir
Copy link

olga-mir commented May 1, 2020

what would be the next step for this issue? The openshift/installer#2745 PR has been merged. Since we are using installer fork: https://github.com/jim-minter/installer/tree/release-4.3-azure I'm assuming we should cherry-picking that commit into that fork?

@jim-minter jim-minter mentioned this issue Oct 31, 2020
Merged
6 tasks
@nilsanderselde nilsanderselde mentioned this issue Jul 14, 2021
Merged
@hawkowl hawkowl mentioned this issue Jan 25, 2022
Merged
6 tasks
jonathan34c added a commit that referenced this issue Oct 31, 2023
@jonathan34c
Merge pull request #3 from niontive/niontive/aks-poc-rp
58bd87c 
Add Simple HTTP Server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Issue or pull request is blocked priority-low Low priority issue or pull request size-medium Size medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 4.5 mjudeikis/ARO-RP
3 participants
@jim-minter @mjudeikis @olga-mir