Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags for go mod compatibility #456

Closed
adambkaplan opened this issue Oct 2, 2019 · 12 comments
Closed

Add tags for go mod compatibility #456

adambkaplan opened this issue Oct 2, 2019 · 12 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@adambkaplan
Copy link
Contributor

API does not have tags, only release branches.

Using tags is more friendly with go mod-based projects.

fyi @openshift/api-reviewers @openshift/api-approvers
@soltysh
Copy link
Member

soltysh commented Oct 15, 2019

@smarterclayton @mfojtik since you've recently touched this, are we planning to start doing it? I think that applies not only to our API but every other one as well (client-go, library-go, etc).

@onlyjob
Copy link

onlyjob commented Dec 15, 2019

IMHO this is a serious outstanding interoperability issue that requires urgent attention. Please tag.

Thanks.

@bbl
Copy link

bbl commented Dec 20, 2019

+1 our old dependent builds are failing now:

go: github.com/openshift/api@v3.9.0+incompatible: unknown revision v3.9.0

@johnmcollier johnmcollier mentioned this issue Jan 6, 2020
Closed
@HVBE
Copy link

HVBE commented Jan 21, 2020

Were tags used here before?

grdryn added a commit to grdryn/operator-lifecycle-manager that referenced this issue Jan 21, 2020
@grdryn
Fix dependency on github.com/openshift/api
1f84eb9 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, and ran `go mod tidy`.

See openshift/api#456 for more info on the
issue.
grdryn added a commit to grdryn/operator-lifecycle-manager that referenced this issue Jan 21, 2020
@grdryn
Fix dependency on github.com/openshift/api
02455b8 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran `go
mod tidy`.

See openshift/api#456 for more info on the
issue.
@grdryn grdryn mentioned this issue Jan 21, 2020
Closed
5 tasks
grdryn added a commit to grdryn/cloud-resource-operator that referenced this issue Jan 21, 2020
@grdryn
🚑 Fix dependency on openshift/api
251f7ab 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a go mod tidy
in any project that depends on it:

```
go: github.com/operator-framework/operator-sdk@v0.12.1-0.20191112211508-82fc57de5e5b requires
	github.com/operator-framework/operator-lifecycle-manager@v0.0.0-20190605231540-b8a4faf68e36 requires
	github.com/openshift/api@v3.9.1-0.20190424152011-77b8897ec79a+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was set an override in the "replace"
section of the go.mod, and ran `go mod tidy` (which changed a bunch of
other things...).

See openshift/api#456 for more info on the issue.
@grdryn grdryn mentioned this issue Jan 21, 2020
Closed
grdryn added a commit to grdryn/cloud-resource-operator that referenced this issue Jan 21, 2020
@grdryn
🚑 Fix dependency on openshift/api
5202cc4 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a go mod tidy
in any project that depends on it:

```
go: github.com/operator-framework/operator-sdk@v0.12.1-0.20191112211508-82fc57de5e5b requires
	github.com/operator-framework/operator-lifecycle-manager@v0.0.0-20190605231540-b8a4faf68e36 requires
	github.com/openshift/api@v3.9.1-0.20190424152011-77b8897ec79a+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was set an override in the "replace"
section of the go.mod, and ran `go mod tidy` (which changed a bunch of
other things...).

See openshift/api#456 for more info on the issue.
grdryn added a commit to grdryn/integreatly-operator that referenced this issue Jan 21, 2020
@grdryn
🚑 Fix dependency on github.com/openshift/api
7c04b4e 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a go mod tidy
in any project that depends on it:

```
go: github.com/operator-framework/operator-sdk@v0.12.1-0.20191112211508-82fc57de5e5b requires
	github.com/operator-framework/operator-lifecycle-manager@v0.0.0-20190605231540-b8a4faf68e36 requires
	github.com/openshift/api@v3.9.1-0.20190424152011-77b8897ec79a+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was set an override in the "replace"
section of the go.mod, and ran go mod tidy (which changed a bunch of
other things...).

See openshift/api#456 for more info on the issue.
@grdryn grdryn mentioned this issue Jan 21, 2020
Closed
@grdryn
Copy link
Member

grdryn commented Jan 21, 2020

This also seems to be related: operator-framework/operator-sdk#2394

@grdryn grdryn mentioned this issue Jan 21, 2020
Closed
@mfojtik
Copy link
Contributor

mfojtik commented Jan 21, 2020

You can use:

go get -u github.com/openshift/api@master
go get -u github.com/openshift/api@release-4.3

To bump the openshift/api in your project. It will resolve to a commit and it is harder to track in go.mod. We are looking into automatic tagging for some repos, but it is not trivial as it might seem.

@HVBE
Copy link

HVBE commented Jan 21, 2020 •
edited
Loading

@mfojtik adding the following to .bashrc also seems to work for the meanwhile GOPROXY=https://proxy.golang.org as an alternative to your solution, at the very least it worked for the specific case we found in the operators used in Integr8ly

@grdryn
Copy link
Member

grdryn commented Jan 22, 2020

Thanks folks! @HubertStefanski's workaround is sufficient for me for the moment, but @mfojtik's plan to have tags again in future sounds like a better eventual solution (some people may not be able to use proxy.golang.org for one reason or another).

@mjudeikis mjudeikis mentioned this issue Jan 22, 2020
Closed
grdryn added a commit to grdryn/operator-lifecycle-manager that referenced this issue Jan 23, 2020
@grdryn
Fix dependency on github.com/openshift/api
194ff26 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran `make vendor`.

See openshift/api#456 for more info on the
issue.
grdryn added a commit to grdryn/operator-lifecycle-manager that referenced this issue Jan 24, 2020
@grdryn
Fix dependency on github.com/openshift/api
9b81c79 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran `make vendor`.

See openshift/api#456 for more info on the
issue.
@cgwalters cgwalters mentioned this issue Feb 3, 2020
Closed
@johnmcollier johnmcollier mentioned this issue Feb 18, 2020
Open
grdryn added a commit to grdryn/operator-lifecycle-manager that referenced this issue Feb 19, 2020
@grdryn
Fix dependency on github.com/openshift/api
14919df 
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a `go mod tidy`
in any project that depends on it:

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```

For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran `make vendor`.

See openshift/api#456 for more info on the
issue.
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this issue May 28, 2020
@raghavendra-talur
go.mod: replace non-existent tag
e47c44d 
The openshift/api project deleted their tags at some point, because of
which we get the following error for go commands:

```
go:
github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible:
invalid pseudo-version: preceding tag (v3.9.0) not found
```

There is at least one more project which is referencing the tag(Noobaa)
which makes it harder to change the require line right now. Therefore, I
have modified the requirement through a replace line.

For more information refer to
openshift/api#456

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@raghavendra-talur raghavendra-talur mentioned this issue May 28, 2020
Merged
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this issue Jun 2, 2020
@raghavendra-talur
go.mod: replace non-existent tag
0e96ea9 
The openshift/api project deleted their tags at some point, because of
which we get the following error for go commands:

```
go:
github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible:
invalid pseudo-version: preceding tag (v3.9.0) not found
```

There is at least one more project which is referencing the tag(Noobaa)
which makes it harder to change the require line right now. Therefore, I
have modified the requirement through a replace line.

For more information refer to
openshift/api#456

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
raghavendra-talur added a commit to raghavendra-talur/ocs-operator that referenced this issue Jun 2, 2020
@raghavendra-talur
go.mod: replace non-existent tag
ba992fe 
The openshift/api project deleted their tags at some point, because of
which we get the following error for go commands:

```
go:
github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible:
invalid pseudo-version: preceding tag (v3.9.0) not found
```

There is at least one more project which is referencing the tag(Noobaa)
which makes it harder to change the require line right now. Therefore, I
have modified the requirement through a replace line.

For more information refer to
openshift/api#456

Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
@RoddieKieley RoddieKieley mentioned this issue Sep 16, 2020
Closed
abstractj pushed a commit to abstractj/keycloak-operator that referenced this issue Sep 23, 2020
The openshift/api project deleted their tags, and now we get the foll…
5f0116e 
…owing error: 

```
go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
```
 

See: [openshift/api#456|openshift/api#456]
abstractj pushed a commit to abstractj/keycloak-operator that referenced this issue Sep 23, 2020
[KEYCLOAK-15710] - Cannot build the Keycloak Operator from master
eb06e33 
The openshift/api project deleted their tags, and now we get the
following error:
``` go:
github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible:
invalid pseudo-version: preceding tag (v3.9.0) not found
```

See: [openshift/api#456|openshift/api#456]
@abstractj abstractj mentioned this issue Sep 23, 2020
Closed
This was referenced Oct 1, 2020
Closed
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2020
@georgettica georgettica mentioned this issue Oct 27, 2020
Merged
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 11, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 21, 2022
Closed
Merged
This was referenced Apr 11, 2023
Closed
Merged
@mx-psi mx-psi mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mfojtik @grdryn @soltysh @onlyjob @adambkaplan @openshift-bot @bbl @openshift-ci-robot @HVBE