Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'Object' cmdlets for flattened parameters #127

Closed
MiYanni opened this issue Jan 30, 2019 · 3 comments
Closed

Remove 'Object' cmdlets for flattened parameters #127

MiYanni opened this issue Jan 30, 2019 · 3 comments
Projects
Release

Comments

@MiYanni
Copy link
Contributor

MiYanni commented Jan 30, 2019

Right now, we generate cmdlets that are for complex objects that have a suffix of Object. However, we flatten a lot of these objects as parameters so these Object cmdlets are not needed.
@deathly809
Copy link
Member

How will you handle flattening arrays of objects? I assume those are exempt from flattening?

@MiYanni
Copy link
Contributor Author

MiYanni commented Feb 7, 2019 •
edited

@deathly809 So, this only applies to flattened singular properties. Meaning, if something has a property Sku of type SkuItem but SkuItem only has (currently) 4 properties or less, we flatten that Sku property so it's properties move up and we no longer use SkuItem type. However, if we had SkuItem[], it would not be flattened and still have a New-AzSkuItemObject cmdlet to create those things.

@fearthecowboy fearthecowboy transferred this issue from Azure/autorest Mar 28, 2019
@fearthecowboy fearthecowboy added this to [P1] Bugs/Feature Changes in Release Mar 28, 2019
@fearthecowboy fearthecowboy moved this from [P1] Bugs/Feature Changes to [P2] Future Bugs/Feature in Release Mar 28, 2019
@MiYanni
Copy link
Contributor Author

MiYanni commented Jul 17, 2019

We no longer generate Object cmdlets.

@MiYanni MiYanni closed this as completed Jul 17, 2019
Release automation moved this from [P1.5] Required for Transition to Done Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deathly809 @MiYanni