Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal UI Format #5

Closed
edm-ms opened this issue Jan 12, 2022 · 2 comments
Closed

Portal UI Format #5

edm-ms opened this issue Jan 12, 2022 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@edm-ms
Copy link
Contributor

edm-ms commented Jan 12, 2022

We need to determine the options and flow for the custom UI.

Pooled / Personal radio button
If pooled then show: load balancing option, users per pool, scaling option, etc.

@edm-ms edm-ms added help wanted Extra attention is needed question Further information is requested labels Jan 12, 2022
@edm-ms edm-ms removed the help wanted Extra attention is needed label Jan 13, 2022
@edm-ms
Copy link
Contributor Author

edm-ms commented Jan 15, 2022

I've made a lot of progress here, and it seems to be coming together. UI testing can be viewed here.

I am going to move the KV selector and Image customizations out of the initial deployment UI. There are a couple of reasons for this.

  1. If we allow a user to select an existing Key Vault the deployment may not work. This is because we create a user assigned identity to access the Key Vault, and an existing vault will not have this identity with proper IAM or vault access policies. An end user selecting one of these vaults may not have IAM permissions to modify the existing vault.
  2. We want to create out own Key Vault to store VM secrets (domain join, local admin password, etc.)

What I propose we do is just create the Key Vault as part of the initial deployment. This will allow the selection of the vault to inject and upload certificates in the image build deployment. Since we will use GUID to help create the name it will be deterministic and allow us to hard-code the selection of just this vault in the image build template.

I am going to replace the existing Image build section with HostPool properties including scaling plans (now GA), and RDP properties.

@edm-ms edm-ms modified the milestone: Initial Working Deployment Jan 15, 2022
@christiankuhtz
Copy link
Contributor

closing as done

danycontre added a commit that referenced this issue Aug 2, 2022
jensheerin pushed a commit that referenced this issue Sep 18, 2022
host.tf and avd.tf file conflict resolved
danycontre pushed a commit that referenced this issue Feb 14, 2023
danycontre pushed a commit that referenced this issue Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants