Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azidentity] DefaultAzureCredential: add exclude_managed_identity_credential, etc. #22866

Closed
letmaik opened this issue May 8, 2024 · 3 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@letmaik
Copy link

letmaik commented May 8, 2024

Feature Request

There should be feature parity with the Python SDK.

Specifically I would like to use exclude_managed_identity_credential, exclude_workload_identity_credential, and exclude_interactive_browser_credential with NewDefaultAzureCredential().

@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@chlowell
Copy link
Member

chlowell commented May 8, 2024

Thanks for opening this issue. There are a couple big reasons we don't plan to add options like these. First, they would encourage people to try to make DefaultAzureCredential work in scenarios where it would be better to use a more specific credential type instead. Using a more specific type is generally the best approach in production because it makes authentication more predictable and robust, and easier to debug when something goes wrong. Second, they would needlessly complicate the API. There's no need to selectively disable parts of DefaultAzureCredential because all the credential types it uses are available separately and ChainedTokenCredential enables building a similar chain of them.

@chlowell chlowell closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@letmaik
Copy link
Author

letmaik commented May 9, 2024

@chlowell That sounds reasonable. I think though those design principles should be established across the different languages, otherwise it becomes confusing why the Python SDK has the options and others don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Development

No branches or pull requests

2 participants