Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Make it possible to pass correlation id through ClientCertificateCredential to MsalConfidentialClient/AcquireTokenForClientParameterBuilder #42283

Open
austvik opened this issue Feb 29, 2024 · 4 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@austvik
Copy link

austvik commented Feb 29, 2024

Library name

Azure.Identity

Please describe the feature.

For tracability I want to add the correlation id to authentication calls which are done through the ClientCertificateCredential (I guess this is an issue for all the different credential classes).

The call is done through the MsalConfidentialClient, which internally uses the client to create a AcquireTokenForClientParameterBuilder.

This builder has a WithCorrelationId, but there is no way to signal to the MsalConfidentialClient through the ClientCertificateCredential that we want to add more parameters to the builder.

Please make it possible to add more parameters (like correlation id) to the authentication calls.

@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Feb 29, 2024
@jsquire jsquire added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-team-triage This issue needs the team to triage. labels Feb 29, 2024
@jsquire
Copy link
Member

jsquire commented Feb 29, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@christothes
Copy link
Member

Hi @austvik - Would wrapping your GetToken calls in HttpPipeline.CreateClientRequestIdScope address your issue?

@christothes christothes added the needs-author-feedback More information is needed from author to address the issue. label Feb 29, 2024
@github-actions github-actions bot removed the needs-team-attention This issue needs attention from Azure service team or SDK team label Feb 29, 2024
Copy link

Hi @austvik. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@austvik
Copy link
Author

austvik commented Mar 1, 2024

I give the CertificateCredential to a Azure.Messaging.EventHubs.Primitives.PartitionReceiver which creates an Azure.Messaging.EventHubs.EventHubConnection with it. EventHubConnection has an InnerClient of type Azure.Messaging.EventHubs.Amqp.AmpqClient which, if it is missing a token, calls AcquireAccessTokenAsync which ends up calling GetTokenAsync.

I can try to wrap all calls to methods of the PartitionReceiver with HttpPipeline.CreateClientRequestIdScope

Thank you!

@github-actions github-actions bot added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
Status: Untriaged
Development

No branches or pull requests

3 participants