You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
joseharriaga3 weeks ago
I think "AssistantMessageContent" could make it sound like this belongs to a message with the "assistant" role. If the issue is that "MessageContent" is too generic, would it help if we called it "ThreadMessageContent" instead? I'm also thinking that any decision we make here might apply to the other Message* classes too.
trrwilson2 weeks ago
Agreed with Jose on "thread" being the best additional information to encode if we go that route. I see the merits of either approach; I'd originally named this ThreadMessageContent in the Azure OpenAI definitions and then dropped the "Thread" in response to feedback that overall names were unnecessarily verbose.
https://apiview.dev/Assemblies/Review/abf39c5b6bd9459f81706dfc751197b5#4915ac9a53044f86ab3dd04613cd405b
KrzysztofCwalina 3 weeks ago
Should this be called AssitantMessageContent?
joseharriaga 3 weeks ago
I think "AssistantMessageContent" could make it sound like this belongs to a message with the "assistant" role. If the issue is that "MessageContent" is too generic, would it help if we called it "ThreadMessageContent" instead? I'm also thinking that any decision we make here might apply to the other Message* classes too.
trrwilson 2 weeks ago
Agreed with Jose on "thread" being the best additional information to encode if we go that route. I see the merits of either approach; I'd originally named this ThreadMessageContent in the Azure OpenAI definitions and then dropped the "Thread" in response to feedback that overall names were unnecessarily verbose.
Is there a codified decision process we should follow when balancing concision and clarity with type names? I noticed there's a bit of a "to do" in the guidelines: https://azure.github.io/azure-sdk/dotnet_introduction.html#model-type-naming
The text was updated successfully, but these errors were encountered: