Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] JsonSerializationOption instances should be reused #43056

Open
sebastienros opened this issue Mar 28, 2024 · 3 comments
Open

[Perf] JsonSerializationOption instances should be reused #43056

sebastienros opened this issue Mar 28, 2024 · 3 comments
Assignees
@ArcturusZhang
Labels
Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@sebastienros
Copy link

https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/machinelearningservices/Azure.ResourceManager.MachineLearning/src/Generated/Models/ManagedComputeIdentity.Serialization.cs#L33

I didn't check if it was done anywhere else.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 28, 2024
@jsquire jsquire added Compute Mgmt This issue is related to a management-plane library. needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Mar 28, 2024
@jsquire
Copy link
Member

jsquire commented Mar 28, 2024

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@ArthurMa1978
Copy link
Member

Thank you @sebastienros for your valuable input, @ArcturusZhang could you review our code generation process to enhance the serialization code?

@ArcturusZhang
Copy link
Member

I am making a change to reuse the instance of ModelReaderWriterOptions of W in this PR: Azure/autorest.csharp#4574
We could consider to do the same for JsonConverters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
Compute customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsquire @sebastienros @ArcturusZhang @ArthurMa1978