Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUERY] Which exception for Azure.AI.OpenAI 2.0.0-beta, System.ClientModel.ClientResultException or Azure.RequestFailedException? #44671

Open
joakimriedel opened this issue Jun 20, 2024 · 2 comments
Open

[QUERY] Which exception for Azure.AI.OpenAI 2.0.0-beta, System.ClientModel.ClientResultException or Azure.RequestFailedException? #44671

joakimriedel opened this issue Jun 20, 2024 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.

Comments

@joakimriedel
Copy link

Library name and version

Azure.AI.OpenAI 2.0.0-beta

Query/Question

In version 1.0.0-beta, for certain errors I could get an Azure.RequestFailedException thrown. After upgrading to 2.0.0-beta it seems to be System.ClientModel.ClientResultException instead.

Could the team please confirm which exception I should expect going forward, and perhaps mention it in the docs / migration guide since I cannot seem to find any information about this.

Environment

No response
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. labels Jun 20, 2024
@github-actions GitHub Actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jpalvarezl @ralph-msft @trrwilson.

@trrwilson
Copy link
Member

Great observation, @joakimriedel, and thank you for getting in touch -- we'll absolutely include this in the migration guide we're working on.

As you saw, the 2.0 library is now based on System.ClientModel (SCM) rather than Azure.Core directly -- this includes using an SCM transport pipeline, which means the exceptions will now all surface as SCM ClientResultException instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakimriedel @trrwilson