Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint print function is missing a forward slash #30

Closed
Triamus opened this issue Nov 14, 2019 · 0 comments
Closed

Endpoint print function is missing a forward slash #30

Triamus opened this issue Nov 14, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@Triamus
Copy link

Triamus commented Nov 14, 2019

I just tested it for blob but assume issue may prevail for other endpoint types. You seem to be missing a forward slash in the print function print.blob_container <- function(x, ...) of the blob endpoint object in AzureStor/R/blob_client_funcs.R.

The function returns as follows

$ cat(sprintf("URL: %s\n", paste0("https://myblob.blob.core.windows.net", "mycontainer")))
> URL: https://myblob.blob.core.windows.netmycontainer 

when it should return

URL: https://myblob.blob.core.windows.net/mycontainer

I could try a pull request but have never done that before on some open source GitHub R project so not sure how helpful that would be (as it would also take some time getting used to the conventions and such). Lmk.

@hongooi73 hongooi73 added the bug Something isn't working label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants