Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (break up) the big monolithic install_moodle.sh & setup_webserver.sh #79

Open
hosungsmsft opened this issue Apr 11, 2018 · 3 comments
Labels
enhancement New feature or request Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Milestone

Comments

@hosungsmsft
Copy link

Currently install_moodle.sh and setup_webserver.sh require a bunch of command line arguments for a single site, which grow more and more and won't be sustainable sooner than later. Ideally those command line parameters should be packed in a config file and passed down to the VM deployment template. It might require using cloud-init as mentioned in #33. I'm raising another issue, because this will also help supporting multiple Moodle sites with a single deployment (#78). Eventually we'd want a config file (for multiple Moodle sites) created/shared/updated on /moodle and let each VMSS VM instance configure its html directories, moodledata directories, and Apache virtual hosts as stated in the config file. The controller VM will need to create that config file based on the deployment-time custom data (for cloud-init) that should replace the install_moodle.sh cmdline parameters, and probably the script itself with something more flexible like a Python script (to facilitate processing the custom data and config file generation better).

@SorraTheOrc SorraTheOrc added enhancement New feature or request Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels Apr 12, 2018
@hosungsmsft hosungsmsft changed the title Replace all the many cmdline parameters to install_moodle.sh & setup_webserver.sh with a config file Refactor (break down) the big monolithic install_moodle.sh & setup_webserver.sh, and also replace all the many cmdline parameters to them with a config file May 1, 2018
@hosungsmsft hosungsmsft added Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP. and removed Priority 1 (may address) Pull Requests very welcome, but we are unlikely to get to this ourselves. labels May 1, 2018
@hosungsmsft hosungsmsft added this to the v1.5.2 milestone May 1, 2018
@hosungsmsft hosungsmsft changed the title Refactor (break down) the big monolithic install_moodle.sh & setup_webserver.sh, and also replace all the many cmdline parameters to them with a config file Refactor (break up) the big monolithic install_moodle.sh & setup_webserver.sh, and also replace all the many cmdline parameters to them with a config file May 11, 2018
@hosungsmsft
Copy link
Author

The later part of this issue ("replace all the many cmdline parameters to them with a config file") was addressed in #140, so the title of this issue will be updated.

@hosungsmsft hosungsmsft changed the title Refactor (break up) the big monolithic install_moodle.sh & setup_webserver.sh, and also replace all the many cmdline parameters to them with a config file Refactor (break up) the big monolithic install_moodle.sh & setup_webserver.sh Jun 1, 2018
@hosungsmsft
Copy link
Author

With #140, we should now aim at replacing the bash scripts with Python scripts that are well-designed/organized and can be run on both Ubuntu and CentOS.

@ummadisudhakar
Copy link
Contributor

separating the ngnix configuration from install_moodle.sh and setup_webserver.sh files.This would reduce the file size in terms of number of lines of code.Right now testing the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority 0 (will address) Pull requests welcome, failing that we will get to this ASAP.
Projects
None yet
Development

No branches or pull requests

3 participants