-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont require github.com token #52
Labels
backlog
Planned for future
Comments
This issue is idle because it has been open for 14 days with no activity. |
Hi @sta-szek, We currently have an engineer who is refactoring this action. We will continue to update you with our progress as we move forward. |
This issue is idle because it has been open for 14 days with no activity. |
The fix should be out soon |
Merged
Fixed with #55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hello, thanks for this action! 🤝
it saved some hours of my work 🍻
however, i have small request.
would it be possible to change the implementation, not to use github.com token for the github api?
i mean this piece of code:
the problem is that we run the action hundreds of thousands of times every day (we have bilions of microservices, each will run it at least 3 times on single PR! and bunch of active developers that are creating PRs every second)
all that, in conjunction, is creating massive attak on github API, which requires github.com token -> as a result, the token is API Rate limited :/
can we somehow use
latest
as version, to fetch latest, but do not query github api?as a result we have blocked pipelines, which is defniately not the way to go.
also, we can consider changing version to some fixed version, but then we need to update the version manually, which is also not the way to go :(
The text was updated successfully, but these errors were encountered: