[Bug] Null Reference Exception Thrown in RegisterCache on Mac

[jfullerton44]

When RegisterCache is run on mac a null reference is thrown in Msal.MacKeyChain.DeleteKey(String serviceName, String accountName). This issue does not appear on linux or windows at the moment.

Issue appears on Mac OS 11.4 (20F71)
Msal version 2.18.7

[trwalke]

Adding P1 as this is throwing a null ref

[bgavrilMS]

@jfullerton44 - looking at the stack trace above, I don't think you are using a recent version of the library.

Microsoft.Identity.Client.MSAL.Extensions is currently at version 2.18.8 and MSAL itself is at 4.35.

MsalCacheStorage.ClearCore was removed by this commit, exactly 2 years ago.

Can you please upgrade to latest versions of MSAL and cache ext and try again?

[jfullerton44]

I updated MSAL to 4.35 and Extensions to 2.18.8 and this is the stack trace now

[jfullerton44]

I seem to have found the issue. When the StorageCreationPropertiesBuilder was being created I needed to add the service and account name using

WithMacKeyChain(
    "msal_service",
     "msal_account");

After I added this the issue went away. This also explains why the issue was only appearing on mac

[bgavrilMS]

Yes, but please add something more descriptive than "msal_service" / "msal_account". Use the name of your app. Open KeyChain app on mac and see how the data is stored there and how these labels are used.