Ignore time part and timezone

CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Fixed
 - Fixed spelling issue in the Swedish translation. [\#97](https://github.com/azuyalabs/yasumi/pull/97)
+- Fixed BetweenFilter to ignore time part and timezone. [\#101](https://github.com/azuyalabs/yasumi/pull/101)
 
 ### Removed
 

src/Yasumi/Filters/BetweenFilter.php

@@ -30,12 +30,12 @@
 class BetweenFilter extends FilterIterator implements Countable
 {
     /**
-     * @var \DateTimeInterface start date of the time frame to check against
+     * @var string start date of the time frame to check against
      */
     private $start_date;
 
     /**
-     * @var \DateTimeInterface end date of the time frame to check against
+     * @var string end date of the time frame to check against
      */
     private $end_date;
 
@@ -61,16 +61,16 @@ public function __construct(
     ) {
         parent::__construct($iterator);
         $this->equal      = $equal;
-        $this->start_date = $start_date;
-        $this->end_date   = $end_date;
+        $this->start_date = $start_date->format('Y-m-d');
+        $this->end_date   = $end_date->format('Y-m-d');
     }
 
     /**
      * @return bool Check whether the current element of the iterator is acceptable
      */
     public function accept(): bool
     {
-        $holiday = $this->getInnerIterator()->current();
+        $holiday = $this->getInnerIterator()->current()->format('Y-m-d');
 
         if ($this->equal && $holiday >= $this->start_date && $holiday <= $this->end_date) {
             return true;

tests/Base/HolidayBetweenFilterTest.php

@@ -132,6 +132,29 @@ public function testHolidaysBetweenDateRangeWithDateTimeImmutable()
         $this->assertNotEquals(\count($holidays), $between->count());
     }
 
+    /**
+     * Tests that BetweenFilter considers the date and ignores timezones and time of day.
+     */
+    public function testHolidaysBetweenDateRangeDifferentTimezone()
+    {
+        $holidays = Yasumi::create('Netherlands', 2016);
+
+        $timezones = ['Pacific/Honolulu', 'Europe/Amsterdam', 'Asia/Tokyo'];
+
+        foreach ($timezones as $timezone) {
+            $between = $holidays->between(
+                new DateTime('01/01/2016', new DateTimeZone($timezone)),
+                new DateTime('01/01/2016', new DateTimeZone($timezone))
+            );
+            $this->assertCount(1, $between);
+
+            $between = $holidays->between(
+                new DateTime('01/01/2016 23:59:59', new DateTimeZone($timezone)),
+                new DateTime('01/01/2016 23:59:59', new DateTimeZone($timezone))
+            );
+            $this->assertCount(1, $between);
+        }
+    }
 
     /**
      * Tests the BetweenFilter with date range where start and end date are exclusive of the comparison.