Add observed holidays for Denmark #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
c960657
force-pushed
the
denmark-observed
branch
from
3176a94
to
3f9bd5c
Compare
stelgenhof
reviewed
May 10, 2018
| @@ -57,7 +57,7 @@ public function initialize() | |||
| $this->addHoliday($this->christmasEve($this->year, $this->timezone, $this->locale, Holiday::TYPE_OFFICIAL)); | |||
| $this->addHoliday($this->christmasDay($this->year, $this->timezone, $this->locale)); | |||
| $this->addHoliday($this->secondChristmasDay($this->year, $this->timezone, $this->locale)); | |||
| $this->addNewYearsEve(); | |||
| $this->addHoliday($this->newYearsEve($this->year, $this->timezone, $this->locale)); | |||
There was a problem hiding this comment.
Shouldn't this change be excluded from this PR since it isn't related to Denmark?
There was a problem hiding this comment.
Both Denmark and Latvia (and many other countries) celebrate New Year's Eve, so I moved newYearsEve() to CommonHolidays to allow reuse. So there is no reason to keep a duplicate implementation in the Latvia class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider for Denmark currently supports what are usually known as holidays (hellidage).
Other days days are also observed:
Also, Denmark observes daylight saving time.