Add 'on' filter #119
Merged
Add 'on' filter #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelgenhof
approved these changes
Nov 22, 2018
There was a problem hiding this comment.
I think everything looks good. 👍
The abstract 'AbstractProvider' class contains a method as well that determines whether a given date is a holiday. However, that method only returns a boolean whereas your filter also supports multiple holidays. Maybe I will refactor that AbstractProvider function to use this filter :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter to select holidays that happen on a given date.
I've added some unit tests but I'm not sure they are comprehensive, so please check this and let me know what else needs testing and if the existing tests need to be broadened.
Thank you!