Check all USA holidays for substitutions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jagers ! I'll have a look tomorrow and merge this. |
stelgenhof
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For USA holidays, per Section 3(a) of Executive Order 11582 of Feb. 11, 1971 and 5 U.S.C. 6103(b), any holiday that falls on a Sunday is moved to Monday and any holiday that falls on a Saturday is moved to Sunday.
This PR changes the USA Provider to check all holidays for potential substitute holidays, not just New Year's Day, Independence Day, and Christmas Day
This addresses issue #91 regarding Veteran's Day that typically falls on November 11, but in 2018 it was observed on 2018-11-12