Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix, Provider\Germany: Pentecost is not an official holiday - except in Brandenburg #334

Closed
wants to merge 2 commits into from

Conversation

fbett
Copy link
Contributor

@fbett fbett commented Apr 2, 2024

Hi,

Pentecost was originally removed from the list of general holidays in #100.
That's because pentecost is not an official holiday (until today) - except in Brandenburg.

I don't know why, it was added again in #225.

So i don't remove pentecost from the list of general holidays again, but it is generally marked as TYPE_OTHER.

@stelgenhof
Copy link
Member

Hi @fbett Thank you for catching this. I am also not sure what the correct type should be as different developers have committed different changes in the past :) Assuming yours is correct, I have enabled the workflow actions.
There is an issue though with a missing test, which you can see here: https://github.com/azuyalabs/yasumi/actions/runs/8523362013/job/23391036796?pr=334#step:9:312

Another error relates to the coding style. I will have a look at that.

Thanks!

@fbett
Copy link
Contributor Author

fbett commented Apr 3, 2024

Hi @stelgenhof, Thanks a lot for your feedback. You are right, there was another test i missed. It's updated now.
I raised the memory_limit on my local machine to run all the tests.

@stelgenhof
Copy link
Member

@fbett I have fixed the code styling issues. Please rebase your branch. If all goes well, we can then merge your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants