Added Romania Provider #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Commit for Romanian Provider
Minor Format fixing
|
Looking great! Let me have a more detailed look tomorrow and I will merge it with the main branch. Will include it in the upcoming 1.6.0 release :) |
|
Great! Please check the Children's Day Test suite in particular. That should be Observance before 2017, with the first celebration in 1950, and National Holiday starting to 2017. |
stelgenhof
reviewed
Jan 4, 2017
| */ | ||
| public function testObservedHolidays() | ||
| { | ||
| $this->assertDefinedHolidays([ |
There was a problem hiding this comment.
This test fails for years before 2016, as this holiday didn't exist yet before 2016. I ran multiple unit tests and it came out as a fail:
Yasumi\tests\Romania\RomaniaTest::testObservedHolidays
Failed asserting that an array has the key 'constantinBrancusiDay'.
Best is to run your unit tests repeatedly, e.g. vendor/bin/phpunit --testsuite=Romania --repeat=100 to ensure nothing is missed.
stelgenhof
requested changes
Jan 4, 2017
Updated rules for Observed Holidays tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Romania Provider and tests