Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the project dependencies to support TS v3 #22

Closed
wants to merge 2 commits into from

Conversation

Jared-Dev
Copy link

Resolves #18

Updates all dependencies to the latest versions as of the PR.

Copy link
Owner

@azz azz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Just a couple of small comments then I'm happy to land it.

"eslint-plugin-prettier": "^3.0.0",
"jest": "^23.6.0",
"prettier": "^1.14.3",
"semantic-release": "^15.10.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"semantic-release": "^15.10.3",
"semantic-release": "^8.0.3",

I'd like to keep this the same as it requires changing the config a bit to upgrade to 15.

@@ -0,0 +1,12035 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file and update yarn.lock instead.

@zw-slime
Copy link

zw-slime commented Nov 8, 2018

when will you merge the request? I need to update typescript.

@aleclarson
Copy link
Collaborator

aleclarson commented Dec 9, 2018

@azz What's the point of using ~ instead of ^ for the typescript version? (I know how they work, but what is ~ fixing here?) edit: Ah, that's only for the dev dependency. Still curious, though!

@aleclarson aleclarson closed this Dec 10, 2018
Repository owner locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants