Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #104

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Conversation

MichaelDeBoey
Copy link
Contributor

BREAKING CHANGE: Node >=10.13.0 is required
BREAKING CHANGE: Prettier ^2.0.0 is required


Closes #101
Closes #102

BREAKING CHANGE: Node >=10.13.0 is required
BREAKING CHANGE: Prettier ^2.0.0 is required
@cgfarmer4
Copy link

cgfarmer4 commented May 15, 2020

+1 for new prettier although I would advocate for not breaking the node version

@MichaelDeBoey
Copy link
Contributor Author

@cgfarmer4 prettier@2.x requires node@10.13.x

@cgfarmer4
Copy link

I just ran it on 8 🤔

@MichaelDeBoey
Copy link
Contributor Author

MichaelDeBoey commented May 15, 2020

The minimal required Node version now is 10.13.0. For our contributors, this means there is no need anymore to jump through hoops to make tests pass on Node 4.

https://prettier.io/blog/2020/03/21/2.0.0.html#drop-support-for-node-versions-older-than-10-6908httpsgithubcomprettierprettierpull6908-by-fiskerhttpsgithubcomfisker

@azz
Copy link
Member

azz commented Aug 21, 2020

@MichaelDeBoey Thanks for this PR and apologies for the delay, I was taking a break from OSS.

This all looks good, and especially after the delay in reviewing, I don't have any issues in pushing a v3 with these changes.

I've just tinkered with the semantic-release setup (bump from v11 to v15), so hopefully this goes out without a hitch. 🤞

@azz azz merged commit 9290ae4 into prettier:master Aug 21, 2020
@azz
Copy link
Member

azz commented Aug 21, 2020

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade prettier dependency to 2.0
3 participants